core: Added changes to make ServerImpl.internalClose() thread-safe #11924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Created this new PR with required changes along with Review points fixes as part of Existing PR #11864 which needs to close as duplicate once this PR merged. |
| @@ -581,6 +586,7 @@ public void close(Status status, Metadata trailers) { | |||
| // clientStreamListener.closed can trigger clientStream.cancel (see code in | |||
| // ClientCalls.blockingUnaryCall), which may race with clientStream.serverClosed as both are | |||
| // calling internalCancel(). | |||
| closeCalled = true; | |||
There was a problem hiding this comment.
Eric had commented that the stream implementation should handle whether close had already been called but this PR is doing it in the InProcessTransport.
There was a problem hiding this comment.
Fixed and moved the changes to AbstractServerStream
…ream implementation.
Fixed the Review comments and PR is Ready for your Re-review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core: Added changes to make ServerImpl.internalClose thread-safe
Fixes: #3746