api: update Status equals&hashCode #11953
Open
+24
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeCqupt
changed the title
|
PTAL @kannanjgithub |
| @@ -656,8 +656,14 @@ private static String parseAsciiStringSlow(byte[] value) { | |||
| * additional fields may be added to Status in the future. | |||
| */ | |||
| @Override | |||
| public boolean equals(Object obj) { | |||
| return super.equals(obj); | |||
| public boolean equals(Object o) { | |||
There was a problem hiding this comment.
The comment suggests to just do comparison on the status code as the description and cause are unlikely to be stable. It may be better to do any handling of the comparison logic at the caller site, i.e., StatusOr.equals in this case. Also whether that comparison should just consider the status code or all 3 fields is another question. I will schedule this for discussion in our next week's API review meeting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11949