-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #2205. Reduce fragility of clipboard related unit tests #2206
Conversation
…fixes_2205_fakeclipboard
97fec8c
to
bc495d0
Compare
@BDisp - Man, I feel your pain. The Clipboard on WSL and Linux is a mysterious beast! I think I made solid progress in making the unit tests more robust with this PR. Please review. @tznind, @BDisp (or anyone else) - please pull this down locally on a Mac AND real Linux install and test it please. I don't have either. |
Can confirm that running Ubuntu laptop things work as expected.
I was able to copy/paste when |
Alright, I think I have everything fixed except the Curses reset issue @BDisp noted. Still trying to figure that one out... |
This is the correct behavior, IMO, and I just fixed a stupid mistake that makes it work this way (which is how it worked before):
|
One that is occur to me is any exception when is thrown deviates the execution of the reset. |
It seems to be fixed now. Perhaps some |
Curses is still acting weird, but at least I got my VS2022/Windows Terminal config working again. The WT team got me a private build with a fix and I'm now unblocked. |
@BDisp - I cannot get breakpoints to hit when debugging in WSL on two different machines. I have searched high and low and cannot find out what I'm doing wrong or have mis-configured. Do you have any suggestions on what I can try? I can't finish this PR until I fix the bug I caused in the TextView/Editor scenario where copy/paste operations corrupt curses. And I can't figure out what's going on without being able to debug! Gracias for any help you can provide! The bug shows itself in many scenarios, not just Editor For example Notepad: |
Oh, and a clue to why VS WSL debugging isn't working is this, shown after I end a WSL debug session:
|
@tig this issue is already in the current develop branch. Will another PR caused this or some Windows update? |
I see other oddities in What, specifically, is the issue you see? (Nevermind, I see you are referring to the Notepad issue: I DO see this in develop.) (And of course, now that I'm trying to get new video of the Editor bug I think I caused, it no longer repros. Sigh.) |
The correct link for others users is only https://developercommunity.visualstudio.com/t/Debugging-dotnet-console-apps-in-VS2022/10242732, otherwise we receive this warning: |
Based on the fact I can no longer reproduce the Editor issue where curses gets corrupted with this PR, I'm going to merge it. The benefits of all the work I did far outweigh an issue that is so hard to repo on WSL. If it repos again, we'll just open another issue for it. |
Fixes #2205