Reduce legacy Windows driver ANSI escape sequence intermediate string allocations #3936
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Proposed Changes
Pull Request checklist
CTRL-K-D
to automatically reformat your files before committing.dotnet test
before commit///
style comments)Drivers
This should be applicable to the other drivers as well. I can of course make the changes if necessary but I have no WSL set up at the moment so I can only test the NetDriver.
UICatalog Benchmark
Average time for me improved from ~22 sec to ~21 sec +/- 1 sec.
Microbenchmarks
Allocations
Before
After