-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #3930 - Splits tests to Tests/UnitTests
, Tests/IntegrationTests
, Tests/StressTests
#3954
Conversation
Another result (after tyring to fix stuff):
|
Sadly, the weird crash is still happening even after all this work:
Highly suspicious that ClearScreenNextIteration_Resets_To_False_After_LayoutAndDraw seems to be the culprit. I've studied the test and code and cannot see what the issue is. Some sort of race condition. I sure wish I could get the dump to be created |
Only |
I think I'll break that out to a separate action. |
This error normally is associated to a code that want running on a terminal but in the Github Actions environments don't really have a real terminal. In these cases it's needed to identify what unit test fail first and doing a stressing test with the fail test and with others together. Normally it's needed to set |
I agree. It only need to build once for all the projects. |
The |
Fixes
Proposed Changes/Todos
Tests/UnitTests
,Tests/IntegrationTests
,Tests/StressTests
Directory.Build.props
to unify settingsDirecotry.Packages.props
to unify package versions./Tests/UnitTestsParallelizable
project and move obviously parallelizable tests.Pull Request checklist:
CTRL-K-D
to automatically reformat your files before committing.dotnet test
before commit///
style comments)