Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3941. v2win/v2net: UICatalog full benchmark suite crashes in Dialogs scenario #3963

Merged
merged 2 commits into from
Mar 8, 2025

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Mar 6, 2025

Fixes

Proposed Changes/Todos

  • Prevents _currentDemoKey always be 0 in the OnApplicationNotifyNewRunState method.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner March 6, 2025 22:22
@tig tig merged commit f26fd28 into gui-cs:v2_develop Mar 8, 2025
11 checks passed
@BDisp BDisp deleted the v2_3941_v2-uicatalog-benchmark-fix branch March 8, 2025 22:52
@BDisp BDisp restored the v2_3941_v2-uicatalog-benchmark-fix branch March 9, 2025 01:34
@BDisp BDisp deleted the v2_3941_v2-uicatalog-benchmark-fix branch March 9, 2025 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2win/v2net: UICatalog full benchmark suite crashes in Dialogs scenario
2 participants