Reduce string allocations in IConsoleOutput implementations #3978
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Proposed Changes
IConsoleOutput.Write(string)
toIConsoleOutput.Write(ReadOnlySpan<char>)
.Console.Out.Write(StringBuilder) -> TextWriter.Write(StringBuilder).
void CSI_WriteCursorPosition(TextWriter, int, int)
alternative tostring CSI_SetCursorPosition(int, int)
.Pull Request Checklist
CTRL-K-D
to automatically reformat your files before committing.dotnet test
before commit///
style comments)UI Catalog benchmark
No noticeable change to times. Both v2win and v2net finished in ~03:48. I'm guessing the v2 application or drivers have input throttling/pacing which kind of makes the benchmark timings moot for them.
For comparison v1 Windows driver finished in ~00:35.
Microbenchmarks
CSI_SetCursorPosition vs CSI_WriteCursorPosition
Allocations
v2net
Reduced string allocations nicely.
v2win
Not that much improvement. Eliminated SetCursorVisibility char array and StringBuilder allocations.