Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3968. Menu appears in wrong place when opened in a subview #3979

Merged
merged 4 commits into from
Mar 13, 2025

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Mar 9, 2025

Fixes

Proposed Changes/Todos

  • Menu is added to the MenuBar's SuperView.
  • ContentMenu's MenuBar is now added to the first Toplevel found and not directly into the Application.Top.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • [ x] I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner March 9, 2025 23:44
@tig tig merged commit 7aae0c2 into gui-cs:v2_develop Mar 13, 2025
11 checks passed
@BDisp BDisp deleted the v2_3968_menu-in-subview-fix branch March 13, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menu appears in wrong place when opened in a subview
2 participants