-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes # 3966. TextField crashes app when pasting unicode surrogate pair #3982
base: v2_develop
Are you sure you want to change the base?
Fixes # 3966. TextField crashes app when pasting unicode surrogate pair #3982
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As part of this PR, would you please move any parallelizable unit tests for TextField to the parallelizable unit tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're asking to move to the same unit test type 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I misunderstand. Can you help me to identify how I can check if an unit test can be parallelizable, please? Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it doesn't use AutoInitShutdown, SetupFakeDriver, Application, MouseGrab, or CM it can probably be moved.
…cs#3985) * shortcut tests * Generic demos * Optimize Margin to not defer draw if there's no shadow
Fixes
Proposed Changes/Todos
Pull Request checklist:
CTRL-K-D
to automatically reformat your files before committing.dotnet test
before commit///
style comments)