Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3984 - Margin w/out shadow should not force draw #3985

Merged
merged 14 commits into from
Mar 13, 2025
Merged

Fixes #3984 - Margin w/out shadow should not force draw #3985

merged 14 commits into from
Mar 13, 2025

Conversation

tig
Copy link
Collaborator

@tig tig commented Mar 13, 2025 •
edited
Loading

Fixes

Proposed Changes/Todos

  • Make Generic demo
  • Build a unit test that demos
  • Fix

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@tig tig self-assigned this Mar 13, 2025
@tig tig changed the title Fixes #3984 - Too much Draw Fixes #3984 - Margin w/out shadow should not force draw Mar 13, 2025
@tig tig marked this pull request as ready for review March 13, 2025 17:12
@tig tig requested review from BDisp and tznind March 13, 2025 17:13
@tig tig merged commit ce7fc04 into gui-cs:v2_develop Mar 13, 2025
11 checks passed
BDisp pushed a commit to BDisp/Terminal.Gui that referenced this pull request Mar 13, 2025
@tig @BDisp
Fixes gui-cs#3984 - Margin w/out shadow should not force draw (gui-…
ab591d1 
…cs#3985)

* shortcut tests

* Generic demos

* Optimize Margin to not defer draw if there's no shadow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BDisp BDisp Awaiting requested review from BDisp

@tznind tznind Awaiting requested review from tznind

Assignees

@tig tig

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'Margin' without shadow should not always cause redraw
1 participant
@tig