Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3986. ContextMenu crashing with right and left arrows #3994

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Mar 16, 2025

Fixes

Proposed Changes/Todos

  • Close menu if selected menu is -1 which mean no menu selected.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@tig
Copy link
Collaborator

tig commented Mar 17, 2025

Thanks for this.

FWIW, in the popover PR I've made really great progress (I think) on menuv2. I'm pretty close to being able to delete the Menu, MenuBar, MenuItem, and ContextMenu with a completely new implementation based on Shortcut and Bar.

My plan is to continue to prototype the Menu stuff a bit more in that PR just to make sure Popover will support it.

Then I'll move on to making sure Autocomplete popups can work.

Then I'll prototype a replacement Combobox.

Once I'm confident a new Menu, popup autocomplete, and combo box can work well via Popover I'll merge in Popover.

THEN I'll do PRs for each of the others.

Just saying this to point out that fixing little bugs in the existing menu/combobox/autocompletepopup code is a waste of energy that could probably be spent elsewhere.

@tig tig merged commit 56c8b20 into gui-cs:v2_develop Mar 17, 2025
11 checks passed
@BDisp BDisp deleted the v2_3986_contextmenu-cursor-keys-fix branch March 17, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ContextMenus now broken in v2 net and win drivers
2 participants