Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HFP-2444 Prevent max score not being achievable #116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

otacke
Copy link
Contributor

@otacke otacke commented Jun 30, 2021

Currently, there are a couple of scenarios that will lead to a maximum score being computed that is higher than the score that can be achieved. In particular, it's possible that a dropzone is set to only accept one element but two elements require to be put onto that dropzone without any alternative. In that case, Drag and Drop currently will issue two points possible while one can only get one.

While there may be cases for Kobayashi-Maru tests, it probably makes more sense to never set the maximum score higher than the achievable score.

When merged in, the calculateMaxScore function will fix this problem. Papi Jo has already verified this claim for a couple of different scenarios, please cmp. https://h5p.org/node/1187680.

@BiLachner
Copy link

Hi,
the error still seems to exist.
Here a freshly created quiz, newest updates of the moodle-Plugin are installed: Download

Here the result:
Screenshot_20220618_104933
And the "Solution":
Screenshot_20220618_110612

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants