Make new monitoring config to be disabled by default #1667
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes issue discussed in https://discord.com/channels/905194001349627914/1351566571050504222/1351611062910451742
Switch logic to direct access to the config.Sections to ensure access to the loaded configuration data are not lostWe later found that's not the case^^
So the bug is the logic was unable to determine whether the YAML has opted into the new
monitoring
configuration or not because it's enabled by default. Therefore, the logic ignored the oldmetrics
configuration altogether.Types of changes
Please make sure to follow these points
Screenshots (If Applicable)
Other Information
Any message for the reviewer or kick off the discussion by explaining why you considered this particular solution, any alternatives etc.