Update hydrological aggregation in model.water
#223
+146
−128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #223 +/- ##
=====================================
Coverage 77.4% 77.4%
=====================================
Files 217 217
Lines 16851 16851
=====================================
Hits 13048 13048
Misses 3803 3803 🚀 New features to boost your workflow:
|
measrainsey
force-pushed
the
water/hydro-agg
branch
from
db30fec to
664a3a5
Compare
measrainsey
force-pushed
the
water/hydro-agg
branch
from
664a3a5 to
4153010
Compare
glatterf42
force-pushed
the
water/hydro-agg
branch
from
4153010 to
3611d71
Compare
khaeru
force-pushed
the
water/hydro-agg
branch
from
3611d71 to
e4b5b75
Compare
- Removes nested for loops - Allow for running multiple selected parameters/variables - Reduces complexity of code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(WIP)
PR to update some of the data processing files in
model.water.data.pre_processing.In an effort to get the code running on my local computer and on the UniCC system, I've had to update some paths and modify the existing code a bit. I've also tried to reduce the complexity of the code by removing
forloops where possible. And also trying reduce the need to manually edit parameters and rerun the code by iterating across all possible parameters.This should not interfere with #106, as all the files I'm modifying in this PR are not being changed #106. So that's also why I am submitting this as a separate PR to
main. If this would better be suited as a merge to thenexus-updbranch instead, please let me know.How to review
TBA
PR checklist