-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Service Stub Pattern using Sentiment Analysis example #3215
Conversation
PR SummaryThis PR introduces the Service Stub pattern, implemented with a Sentiment Analysis example. It includes a Changes
autogenerated by presubmit.ai |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM!
Review Summary
Commits Considered (1)
- 7c11cba: Add Service Stub Pattern using Sentiment Analysis example
Files Processed (10)
- pom.xml (1 hunk)
- service-stub/README.md (1 hunk)
- service-stub/pom.xml (1 hunk)
- service-stub/src/main/java/com/iluwatar/servicestub/App.java (1 hunk)
- service-stub/src/main/java/com/iluwatar/servicestub/RealSentimentAnalysisServer.java (1 hunk)
- service-stub/src/main/java/com/iluwatar/servicestub/SentimentAnalysisServer.java (1 hunk)
- service-stub/src/main/java/com/iluwatar/servicestub/StubSentimentAnalysisServer.java (1 hunk)
- service-stub/src/test/java/com/iluwatar/servicestub/AppTest.java (1 hunk)
- service-stub/src/test/java/com/iluwatar/servicestub/RealSentimentAnalysisServerTest.java (1 hunk)
- service-stub/src/test/java/com/iluwatar/servicestub/StubSentimentAnalysisServerTest.java (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM!
Review Summary
Commits Considered (1)
- d727e99: Fix Checkstyle issues
Files Processed (5)
- service-stub/src/main/java/com/iluwatar/servicestub/App.java (1 hunk)
- service-stub/src/main/java/com/iluwatar/servicestub/RealSentimentAnalysisServer.java (1 hunk)
- service-stub/src/main/java/com/iluwatar/servicestub/StubSentimentAnalysisServer.java (1 hunk)
- service-stub/src/test/java/com/iluwatar/servicestub/AppTest.java (1 hunk)
- service-stub/src/test/java/com/iluwatar/servicestub/RealSentimentAnalysisServerTest.java (1 hunk)
Actionable Comments (0)
Skipped Comments (0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM!
Review Summary
Commits Considered (1)
- 9a1cccc: Suppress Sonar warning for Random usage in RealSentimentAnalysisServer
Files Processed (1)
- service-stub/src/main/java/com/iluwatar/servicestub/RealSentimentAnalysisServer.java (1 hunk)
Actionable Comments (0)
Skipped Comments (1)
-
service-stub/src/main/java/com/iluwatar/servicestub/RealSentimentAnalysisServer.java [37-41]
performance: "Improve latency simulation in
RealSentimentAnalysisServer
."
|
Looks good! Thank you for the contribution 🎉 @all-contributors please add @johnklint81 for code |
I've put up a pull request to add @johnklint81! 🎉 |
This PR introduces the Service Stub Pattern, demonstrated through a Sentiment Analysis example.
Fixes #381.