-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qat: init: detect all system QAT devices #2000
base: main
Are you sure you want to change the base?
Conversation
demo/qat-init.sh
Outdated
@@ -30,7 +30,7 @@ check_config() { | |||
sysfs_config() { | |||
if [ "$SERVICES_ENABLED_FOUND" = "TRUE" ]; then | |||
for dev in $DEVS; do | |||
DEVPATH="/sys/bus/pci/devices/0000:$dev" | |||
DEVPATH=$(realpath /sys/bus/pci/devices/????:"$dev") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a bit far fetching, but in theory there could be two (or more) devices that resolve with this path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Tuomas & Mikko, apologies for delay on reviewing this PR - we were trying to get a vCMTS release completed.
I won't be able to test this for a while as the server which showed the initial problem is out-of-action for a while.
However your comment is accurate here, in that it would actually resolve to 2 devices on our server, so not far-fetched at all.
Our devices had the following addresses
- 0000:01:00.0
- 0000:0b:00.0
- 0001:01:00.0
- 0001:0b:00.0
So with $dev == 01:00.0
, the realpath /sys/bus/pci/devices/????:"$dev"
command would give
/sys/bus/pci/devices/0000:01:00.0
/sys/bus/pci/devices/0001:01:00.0
So there would need to be a loop on those 2 paths.
But the global $DEVS
would probably include 01:00.0
twice in this case, so you'd also need to ensure that the devices are not configured twice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dcoyle-intel, then this patch needs more tuning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for checking this, will fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might have broken something:
initContainerStatuses:
- containerID: containerd://30a2e82553980cc90b017e3a169c3cfbdb1f0b97b5db6b80fdc82daba0be7be6
image: 192.168.33.10:5000/intel/intel-qat-initcontainer:0.32.1-e2e-spr
imageID: 192.168.33.10:5000/intel/intel-qat-initcontainer@sha256:86a0310df800b62bd7d4e7026a1766b4ee597279d584f3270fe4fb5463aacedb
lastState:
terminated:
containerID: containerd://9e526dd45848b3fd8d6fbe9cf8bce1f43d02cbaa2d209712b16e822779423b42
exitCode: 1
finishedAt: "2025-03-19T11:08:10Z"
reason: Error
startedAt: "2025-03-19T11:08:09Z"
name: intel-qat-initcontainer
ready: false
restartCount: 4
started: false
state:
terminated:
containerID: containerd://30a2e82553980cc90b017e3a169c3cfbdb1f0b97b5db6b80fdc82daba0be7be6
exitCode: 1
finishedAt: "2025-03-19T11:08:52Z"
reason: Error
startedAt: "2025-03-19T11:08:51Z"
It has restarted 4 times so it doesn't look like a normal error with gnr-d.
Yeah, I need to take a closer look. I only tested the added lines manually (they worked)... |
Signed-off-by: Mikko Ylinen <[email protected]>
Signed-off-by: Mikko Ylinen <[email protected]>
QAT tests are passing now. |
Signed-off-by: Mikko Ylinen <[email protected]>
Fixes: #1999