Update README #116
Merged
Update README #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yathomasi
reviewed
Nov 10, 2022
| - customPropertiesConfig: object config passed to `postcss-custom-properties` | ||
|
|
||
| - colorModConfig: object config passed to `postcss-color-mod` | ||
|
|
There was a problem hiding this comment.
I think a few other options were added too on #33. Can we also add those, or do we want to add them through another PR?
There was a problem hiding this comment.
I'll open a draft ticket on the board and assign myself for a follow-up after I'm done with plausible
There was a problem hiding this comment.
Actually, for now I'll add a super-basic list so we at least have them. I'll leave the ticket for more elaboration later.
There was a problem hiding this comment.
Just added the new commands and some more elaboration on others. Still needs some work, but it'll serve as a base.
rogermparent
temporarily deployed
to
gatsby-theme-update-rea-ffjbab
rogermparent
temporarily deployed
to
gatsby-theme-update-rea-ffjbab
rogermparent
temporarily deployed
to
gatsby-theme-update-rea-ffjbab
rogermparent
changed the title
yathomasi
approved these changes
Nov 11, 2022
README.md
Outdated
|
|
||
| - customPropertiesConfig: object config passed to `postcss-custom-properties` | ||
| This function will be used to |
There was a problem hiding this comment.
I believe this is incomplete.
rogermparent
temporarily deployed
to
gatsby-theme-update-rea-ffjbab
rogermparent
requested a deployment
to
gatsby-theme-update-rea-ffjbab
rogermparent
temporarily deployed
to
gatsby-theme-update-rea-ffjbab
rogermparent
changed the title
rogermparent
commented
Nov 11, 2022
Comment on lines
18
to
20
| filesystem: Joi.boolean().default(true), | ||
| glossaryDirectory: Joi.string().default( | ||
| glossaryPath: Joi.string().default( | ||
| path.resolve('content', 'docs', 'user-guide', 'basic-concepts') |
There was a problem hiding this comment.
incomplete rename from before
rogermparent
added a commit
that referenced
this pull request
Nov 11, 2022
* Remove unused options from README and plugin options schema * Add new options to the README and actually indent the default options * Fix formatting and make Default always on top * Move README * Finish incomplete item and make postCssPlugins block behave with linter * Add main header and intro blurb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a few goals
pluginOptionsSchemafixes #118, but just barely. We can probably do with more elaboration and formatting.