jakarta remote endpoint classes should not send message in case of en…

…coding failure

Signed-off-by: Lachlan Roberts <lachlan.p.roberts@gmail.com>

jetty-ee10/jetty-ee10-websocket/jetty-ee10-websocket-jakarta-common/src/main/java/org/eclipse/jetty/ee10/websocket/jakarta/common/JakartaWebSocketAsyncRemote.java

@@ -126,6 +126,7 @@ else if (encoder instanceof Encoder.TextStream textStreamEncoder)
                 MessageWriter writer = newMessageWriter();
                 writer.setCallback(new SendHandlerCallback(handler));
                 textStreamEncoder.encode(data, writer);
+                writer.close();
             }
             catch (EncodeException | IOException e)
             {
@@ -154,6 +155,7 @@ else if (encoder instanceof Encoder.BinaryStream binaryStreamEncoder)
                 MessageOutputStream out = newMessageOutputStream();
                 out.setCallback(callback);
                 binaryStreamEncoder.encode(data, out);
+                out.close();
             }
             catch (EncodeException | IOException e)
             {

jetty-ee10/jetty-ee10-websocket/jetty-ee10-websocket-jakarta-common/src/main/java/org/eclipse/jetty/ee10/websocket/jakarta/common/JakartaWebSocketRemoteEndpoint.java

@@ -148,57 +148,48 @@ else if ((messageType == OpCode.TEXT) && (opcode == OpCode.BINARY))
         }
     }
 
+    @SuppressWarnings({"rawtypes", "unchecked"})
     public void sendObject(Object data, Callback callback) throws IOException, EncodeException
     {
         try
         {
             assertMessageNotNull(data);
             if (LOG.isDebugEnabled())
-            {
                 LOG.debug("sendObject({}, {})", data, callback);
-            }
 
             Encoder encoder = session.getEncoders().getInstanceFor(data.getClass());
             if (encoder == null)
-            {
                 throw new IllegalArgumentException("No encoder for type: " + data.getClass());
-            }
 
-            if (encoder instanceof Encoder.Text)
+            if (encoder instanceof Encoder.Text textEncoder)
             {
-                Encoder.Text text = (Encoder.Text)encoder;
-                String msg = text.encode(data);
+                String msg = textEncoder.encode(data);
                 sendFrame(new Frame(OpCode.TEXT).setPayload(msg), callback, batch);
                 return;
             }
 
-            if (encoder instanceof Encoder.TextStream)
+            if (encoder instanceof Encoder.TextStream textStreamEncoder)
             {
-                Encoder.TextStream etxt = (Encoder.TextStream)encoder;
-                try (MessageWriter writer = newMessageWriter())
-                {
-                    writer.setCallback(callback);
-                    etxt.encode(data, writer);
-                }
+                MessageWriter writer = newMessageWriter();
+                writer.setCallback(callback);
+                textStreamEncoder.encode(data, writer);
+                writer.close();
                 return;
             }
 
-            if (encoder instanceof Encoder.Binary)
+            if (encoder instanceof Encoder.Binary binaryEncoder)
             {
-                Encoder.Binary ebin = (Encoder.Binary)encoder;
-                ByteBuffer buf = ebin.encode(data);
+                ByteBuffer buf = binaryEncoder.encode(data);
                 sendFrame(new Frame(OpCode.BINARY).setPayload(buf), callback, batch);
                 return;
             }
 
-            if (encoder instanceof Encoder.BinaryStream)
+            if (encoder instanceof Encoder.BinaryStream binaryStreamEncoder)
             {
-                Encoder.BinaryStream ebin = (Encoder.BinaryStream)encoder;
-                try (MessageOutputStream out = newMessageOutputStream())
-                {
-                    out.setCallback(callback);
-                    ebin.encode(data, out);
-                }
+                MessageOutputStream out = newMessageOutputStream();
+                out.setCallback(callback);
+                binaryStreamEncoder.encode(data, out);
+                out.close();
                 return;
             }