Fix issues with WebSocket UpgradeRequest after upgrade is complete #12877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
…UpgradeRequest' into fix/jetty-12.1.x/11294/WebSocketUpgradeRequest
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #11294
replaces PR #12861
The
UpgradeRequest/UpgradeResponseinterfaces are available from theSessionin the Jetty WebSocket API.These can be accessed after the upgrade, this PR introduces testing for these methods and fixes the ones which do not work.
For the EE10/EE11 environment it is possible for people to downcast the
UpgradeRequestto aJettyServerUpgradeRequest, in EE11 these methods now throw ISE after the upgrade, as they are only indented to be used during the negotiation.