Migrate JS to TS and Test Files to Node.js Native Test runner : Juicy-coupon-bot renovation #25

hxrshxz · 2025-03-08T17:13:52Z

Migrate the files to Typescript and testing files to use new node.js native test runner for testing #24

Files to Migrate ( JS -> TS )

Test Files to Migrate ( Chai , Mocha -> Node.js Native Test Runner )

Linter

Configure Linter to run for TS Files

hxrshxz · 2025-03-15T10:32:13Z

Just some linting errors left

Screencast.from.2025-03-15.16-01-15.mp4

hxrshxz · 2025-03-15T16:24:31Z

node:test APIs returning Promises clashes with no-floating-promises lint rule nodejs/node#51292
Floating Promise Issue
There seems to be an issue with the Node.js test runner regarding floating promises which explains why the test files are showing the following. Based on the sources, disabling it is fine, so I have excluded the test file from ESLint

J12934

code itself looks pretty good to me 👍

unfortunatly the npm deps can't be installed right now, see pipeline logs.

also this project (in ccontrast to the main juiceshop repo) has a package-lock checked in, please make sure to also commit the changes to it when updating dependencies

J12934 · 2025-03-16T20:07:35Z

package.json

    "chai": "^4.2.0",
    "coveralls": "^3.1.0",
-    "mocha": "^7.2.0",
+    "eslint": "^8.57.1",
+    "eslint-config-standard-with-typescript": "^43.0.1",
+    "eslint-plugin-import": "^2.28.1",
+    "eslint-plugin-n": "^17.16.2",
+    "eslint-plugin-node": "^11.1.0",
+    "eslint-plugin-promise": "^7.2.1",
+    "mocha": "^10.4.0",
    "nyc": "^15.1.0",


there still seem to be some (now) unused testing dependencies in here

hxrshxz · 2025-03-16T20:37:39Z

Donee 👍

J12934 · 2025-03-17T22:01:21Z

.github/workflows/ci.yml

@@ -26,7 +26,7 @@ jobs:
          node-version: 20
          cache: npm
      - name: "Install application"
-        run: npm install --ignore-scripts
+        run: npm install --ignore-scripts --legacy-peer-deps


Why is this needed? This repo (in contrast to the main repo) shouldn't have any sec bulbs in it and the dependencies should install cleanly

J12934 · 2025-03-17T22:01:45Z

.eslintrc.cjs

+      parser: '@typescript-eslint/parser',
+      rules: {
+        "no-void": "off", // conflicting with recommendation from @typescript-eslint/no-floating-promises
+        // FIXME warnings below this line need to be checked and fixed.


Are all these really needed? Or just ported over?

I initially ported them over, but I have now fixed it. 😅

J12934 · 2025-03-17T22:02:19Z

.eslintrc.cjs

+  ],
+  plugins: ["@typescript-eslint"],
+  env: {
+    browser: true,


Why are all these unused env enabled?

uhm same i ported these too it's fixed now

J12934 · 2025-03-17T22:04:14Z

package.json

+    "eslint": "^8.57.1",
+    "eslint-config-standard-with-typescript": "^43.0.1",
+    "eslint-plugin-import": "^2.28.1",
+    "eslint-plugin-n": "^17.16.2",


Why is this pulling in the plugin-n and the plugin-node that the n plugin is replacing?

I wasn't aware that the n plugin replaces the node plugin. thank you

J12934

Can you have another look over the code style formatter? It still doesn't seem to be working/ correct. E.g the code is still using semicolons, this doesn't match the juice-shop repo

J12934 · 2025-03-19T06:52:34Z

.github/workflows/lint-fixer.yml

@@ -10,7 +10,7 @@ jobs:
        uses: actions/checkout@v2
      - name: Install Linter
        run: |
-          npm install --ignore-scripts
+          npm install --ignore-scripts --legacy-peer-deps


Still leftover

hxrshxz · 2025-03-19T07:09:38Z

Can you have another look over the code style formatter? It still doesn't seem to be working/ correct. E.g the code is still using semicolons, this doesn't match the juice-shop repo

i actually misunderstood initially and intentionally added double quotes and semicolon now i have removed that rule

bkimminich · 2025-03-19T09:26:54Z

CI/CD is running...

bkimminich · 2025-03-19T09:28:51Z

I think we're just one npm run lint:fix away from merging this one! 🚀

hxrshxz added 4 commits March 8, 2025 22:09

Initialize tsConfig

ae4884c

migrate blueSkyPost to Ts

ee0cd10

migrate logger to Ts

b759660

remove comments from tsConfig

3ad7c94

pull-request-size bot added the size/M label Mar 8, 2025

hxrshxz changed the title ~~Migrating from Vanila Js to Ts~~ Migrated blueSkyPost and logger Mar 8, 2025

hxrshxz marked this pull request as draft March 8, 2025 17:35

hxrshxz force-pushed the master branch 3 times, most recently from 8cad78a to 3ad7c94 Compare March 8, 2025 19:01

hxrshxz added 7 commits March 9, 2025 00:32

use nodenext module

148e003

modified gitignore and tsconfig

c78f238

add post interface

cd112e7

blueSkyPost migrated

d0e4d9e

mastodonPost migrated

fbd98a8

redditPost migrated

21e5516

make util for generateCoupon

9c5c645

pull-request-size bot added size/L and removed size/M labels Mar 9, 2025

hxrshxz added 2 commits March 10, 2025 12:33

currentCoupon migrated

0e00fa0

randomDiscount migrated

e255212

hxrshxz changed the title ~~Migrated blueSkyPost and logger~~ Migrate from JS to TS Mar 10, 2025

hxrshxz added 8 commits March 11, 2025 12:44

publishReddit migrated

ab200d4

add types.ts for type definitions

8d601b5

publishBlueSky migrated

ad55cf4

publishMastodon migrated

9fd5055

Merge branch 'master' of https://github.com/juice-shop/juicy-coupon-bot

48b2eb5

index.js migrated

05f8776

juicy-coupon-bot migrated

6fae982

modified package.json

37d72e5

hxrshxz added 3 commits March 15, 2025 15:25

minor fixes

8962819

add eslint

5f40b0c

ESLint fixes using npm run lint:fix

e2ce453

hxrshxz added 2 commits March 15, 2025 17:32

fix ESLint errors

30fb444

exclude test files from EsLint

017368d

hxrshxz requested a review from J12934 March 15, 2025 16:24

J12934 requested changes Mar 16, 2025

View reviewed changes

hxrshxz added 2 commits March 17, 2025 02:04

removed unused dependencies and fix workflows errors

c8aba86

update package-lock.json

4f5de48

hxrshxz requested a review from J12934 March 16, 2025 20:36

J12934 requested changes Mar 17, 2025

View reviewed changes

hxrshxz added 3 commits March 18, 2025 16:15

fix package.json and resolve peer dependency conflicts

4c2fdd6

fix .eslint file and ts lint errors

df56abd

add package-lock.json

5358eb4

hxrshxz force-pushed the master branch from be29793 to 5358eb4 Compare March 18, 2025 10:48

hxrshxz requested a review from J12934 March 18, 2025 10:54

J12934 requested changes Mar 19, 2025

View reviewed changes

hxrshxz added 3 commits March 19, 2025 12:37

modify eslint rules to match jucie shop

42cc7b5

run lint:fix with new rules

0207de6

fix leftovers

243cfd9

hxrshxz requested a review from J12934 March 19, 2025 07:10

lint fix

9a4fa51

J12934 approved these changes Mar 20, 2025

View reviewed changes

bkimminich merged commit 903ee68 into juice-shop:master Mar 21, 2025
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate JS to TS and Test Files to Node.js Native Test runner : Juicy-coupon-bot renovation #25

Migrate JS to TS and Test Files to Node.js Native Test runner : Juicy-coupon-bot renovation #25

hxrshxz commented Mar 8, 2025 •

edited

Loading

hxrshxz commented Mar 15, 2025

hxrshxz commented Mar 15, 2025 •

edited

Loading

J12934 left a comment

J12934 Mar 16, 2025

hxrshxz commented Mar 16, 2025

J12934 Mar 17, 2025

J12934 Mar 17, 2025

hxrshxz Mar 18, 2025

J12934 Mar 17, 2025

hxrshxz Mar 18, 2025

J12934 Mar 17, 2025

hxrshxz Mar 18, 2025

J12934 left a comment

J12934 Mar 19, 2025

hxrshxz Mar 19, 2025

hxrshxz commented Mar 19, 2025

bkimminich commented Mar 19, 2025

bkimminich commented Mar 19, 2025

Migrate JS to TS and Test Files to Node.js Native Test runner : Juicy-coupon-bot renovation #25

Migrate JS to TS and Test Files to Node.js Native Test runner : Juicy-coupon-bot renovation #25

Conversation

hxrshxz commented Mar 8, 2025 • edited Loading

Files to Migrate ( JS -> TS )

Test Files to Migrate ( Chai , Mocha -> Node.js Native Test Runner )

Linter

hxrshxz commented Mar 15, 2025

Just some linting errors left

hxrshxz commented Mar 15, 2025 • edited Loading

J12934 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hxrshxz commented Mar 16, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

J12934 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hxrshxz commented Mar 19, 2025

bkimminich commented Mar 19, 2025

bkimminich commented Mar 19, 2025

hxrshxz commented Mar 8, 2025 •

edited

Loading

hxrshxz commented Mar 15, 2025 •

edited

Loading