Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add filter/sort e2e for incidents page #4062

Merged
merged 20 commits into from
Mar 23, 2025

Conversation

skynetigor
Copy link
Contributor

@skynetigor skynetigor commented Mar 16, 2025

Closes #3819

📑 Description

  • Add E2E test for static facets (status, severity, source)
  • Add E2E test for custom facet pointing to alert associated with incidents
  • Add E2E test for sorting by creation_time
  • Add required selectors for elements to obtain easier access to elements from E2E tests

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

Copy link

vercel bot commented Mar 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Mar 23, 2025 8:45am

Copy link

codecov bot commented Mar 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.12%. Comparing base (d667aaf) to head (520e446).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4062       +/-   ##
===========================================
- Coverage   47.03%   31.12%   -15.92%     
===========================================
  Files         165       92       -73     
  Lines       16210    10066     -6144     
===========================================
- Hits         7625     3133     -4492     
+ Misses       8585     6933     -1652     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@skynetigor skynetigor marked this pull request as ready for review March 16, 2025 22:44
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Mar 16, 2025
@shahargl
Copy link
Member

@skynetigor looks good, just wrap the tests with "try/except" and use save_failure_artifacts on except

@skynetigor skynetigor changed the title fix: Add e2e for incidents page fix: Add filter/sort e2e for incidents page Mar 19, 2025
Copy link
Contributor

@VladimirFilonov VladimirFilonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skynetigor skynetigor merged commit 2aaf4a2 into main Mar 23, 2025
15 checks passed
@skynetigor skynetigor deleted the 3819_add_e2e_for_incidents_page branch March 23, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: No filter/sort E2E tests for Incidents page
3 participants