-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add filter/sort e2e for incidents page #4062
Conversation
… in order to be able to properly display severity dropdown in incident creation modal
…ation' into 3819_add_e2e_for_incidents_page
…or improved testing
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4062 +/- ##
===========================================
- Coverage 47.03% 31.12% -15.92%
===========================================
Files 165 92 -73
Lines 16210 10066 -6144
===========================================
- Hits 7625 3133 -4492
+ Misses 8585 6933 -1652 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@skynetigor looks good, just wrap the tests with "try/except" and use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #3819
📑 Description
✅ Checks
ℹ Additional Information