-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packit: Add identifier for each copr_build job #943
Open
ansasaki
wants to merge
1
commit into
keylime:master
Choose a base branch
from
ansasaki:add_identifier_copr_build
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
sarroutbi
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
116d597
to
00380e3
Compare
sergio-correia
approved these changes
Feb 25, 2025
/packit test |
9db434c
to
8e7b29c
Compare
Following guidance from packit team, and as documented in [1], add an identifier for each `copr_build` job in the packit configuration. This can help packit to properly identify the jobs and report the results properly, avoiding checks to hang. [1] https://packit.dev/docs/configuration/upstream/copr_build#optional-parameters Signed-off-by: Anderson Toshiyuki Sasaki <[email protected]>
8e7b29c
to
014d0ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following guidance from packit team, and as documented in [1], add an identifier for each
copr_build
job in the packit configuration.This can help packit to properly identify the jobs and report the results properly, avoiding checks to hang.
[1] https://packit.dev/docs/configuration/upstream/copr_build#optional-parameters