Keep proper data type for JSON arrays between conversions. & Fixed conversions for nested JSON arrays and single element Array #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Second commit fixes a lot of conversion issues where there are JSON arrays (even nested) as mentioned in my comment on #7 |
kra3
changed the title
|
Do you have an example for such an problematic scenario? |
| @@ -974,6 +980,12 @@ private boolean isNullObject(Element element) { | |||
| && (element.getAttribute(addJsonPrefix("class")) != null && element.getAttribute(addJsonPrefix("type")) != null)) { | |||
| return true; | |||
| } | |||
| // String clazz = getClass(element); | |||
There was a problem hiding this comment.
These are new code, which is introduced as part of development, should be cleaned up from code base.
|
Transforming from XML (elements with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you convert a JSON array into XML and back to JSON, every data types in the array will be converted to string.
ie.,
{"k": [34, true, "val"]}-> xml -> json =>{"k": ["34", "true", "val"]}That's fixed in this commit as is done for JSONObjects.
Second commit does proper conversions for following cases (multi array nesting is now possible):
[['val', 32]]-> xml -> json =>[['val', 32]][32]-> xml -> json =>[32]