-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP feat(frontend,backend): Remove deprecated Python-based Visualizations #11724
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @Zxenith. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
visualization server removed Signed-off-by: Akarshan <[email protected]>
Signed-off-by: Akarshan <[email protected]>
5df7e25
to
5ffbac6
Compare
Signed-off-by: Akarshan Nirwan <[email protected]>
/ok-to-test |
Approvals successfully granted for pending runs. |
Hey @Zxenith, are you working on this PR? |
@milinddethe15 yes I am still working on it in my local environment. Sorry about the delay, still debugging :) |
@Zxenith @milinddethe15 you can also work on it together :-) Maybe have a zoom call together. In the end it is a revival / rebase of #11134 |
@juliusvonkohout absolutely will do that! It would be much easier for us both if we work on the PR together. @milinddethe15 can I contact you via mail? |
Yes, sure |
Signed-off-by: milinddethe15 <[email protected]>
Signed-off-by: milinddethe15 <[email protected]>
remove unused imports
/retest |
Signed-off-by: Akarshan Nirwan <[email protected]>
/retest |
/ok-to-test |
Approvals successfully granted for pending runs. |
… server >> Signed-off-by: Zxenith <[email protected]> Signed-off-by: Akarshan <[email protected]>
/retest |
Description of your changes:
Removes deprecated Python-based visualizations, including predefined and custom categories, along with the visualization server.
Fixes: #11133
It is a revival of #11134
Checklist: