Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP feat(frontend,backend): Remove deprecated Python-based Visualizations #11724

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Zxenith
Copy link

@Zxenith Zxenith commented Mar 4, 2025

Description of your changes:
Removes deprecated Python-based visualizations, including predefined and custom categories, along with the visualization server.

Fixes: #11133

It is a revival of #11134

Checklist:

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chensun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Hi @Zxenith. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Zxenith added 2 commits March 5, 2025 04:57
visualization server removed

Signed-off-by: Akarshan <[email protected]>
@Zxenith Zxenith force-pushed the remove-visualization-server branch from 5df7e25 to 5ffbac6 Compare March 4, 2025 23:28
@Zxenith Zxenith changed the title feat(frontend,backend): Remove deprecated Python-based Visualizations WIP feat(frontend,backend): Remove deprecated Python-based Visualizations Mar 5, 2025
@hbelmiro
Copy link
Contributor

hbelmiro commented Mar 5, 2025

/ok-to-test

Copy link

github-actions bot commented Mar 5, 2025

Approvals successfully granted for pending runs.

@milinddethe15
Copy link

Hey @Zxenith, are you working on this PR?

@Zxenith
Copy link
Author

Zxenith commented Mar 11, 2025

Hey @Zxenith, are you working on this PR?

@milinddethe15 yes I am still working on it in my local environment. Sorry about the delay, still debugging :)

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Mar 17, 2025

@Zxenith @milinddethe15 you can also work on it together :-) Maybe have a zoom call together. In the end it is a revival / rebase of #11134

@juliusvonkohout juliusvonkohout added this to the KFP 2.5.0 milestone Mar 17, 2025
@Zxenith
Copy link
Author

Zxenith commented Mar 17, 2025

@juliusvonkohout absolutely will do that! It would be much easier for us both if we work on the PR together. @milinddethe15 can I contact you via mail?

@milinddethe15
Copy link

@milinddethe15 can I contact you via mail?

Yes, sure

milinddethe15 and others added 3 commits March 18, 2025 19:51
Signed-off-by: milinddethe15 <[email protected]>
@milinddethe15
Copy link

/retest

@milinddethe15
Copy link

/retest

@hbelmiro
Copy link
Contributor

/ok-to-test

Copy link

Approvals successfully granted for pending runs.

@Zxenith
Copy link
Author

Zxenith commented Mar 19, 2025

/retest

@juliusvonkohout
Copy link
Member

@hbelmiro @HumairAK i think the test failures come from the removal of the deprecated old visualization server. May we remove the tests / code for it ? Normal v1 pipelines run without it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] remove long-deprecated python based visualizations
4 participants