Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Shebang and use docker manifest instead of crane #2405

Merged
merged 1 commit into from
Mar 18, 2025
Merged

Add Shebang and use docker manifest instead of crane #2405

merged 1 commit into from
Mar 18, 2025
+5 −3

Conversation

ElijahQuinones
Copy link
Member

@ElijahQuinones ElijahQuinones commented Mar 17, 2025 •
edited
Loading

What type of PR is this?

/kind cleanup

What is this PR about? / Why do we need it?

This CR adds the shebang line and uses docker manifest instead of crane so it can be run by CI

How was this change tested?

CI

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 17, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 17, 2025
@github-actions GitHub Actions
Copy link

Code Coverage Diff

This PR does not change the code coverage

AndrewSirenko
AndrewSirenko approved these changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@AndrewSirenko AndrewSirenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 17, 2025
@ElijahQuinones
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2025
@ElijahQuinones ElijahQuinones changed the title Add Shebang to test-images.sh Add Shebang and use docker manifest instead of crane Mar 18, 2025
@torredil
Copy link
Member

/retest

@torredil
Copy link
Member

/test pull-aws-ebs-csi-driver-image-test

@ElijahQuinones
Copy link
Member Author

/retest

@torredil
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndrewSirenko, torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [AndrewSirenko,torredil]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0ec6a9c into kubernetes-sigs:master Mar 18, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewSirenko AndrewSirenko AndrewSirenko approved these changes

@torredil torredil Awaiting requested review from torredil

Assignees

@AndrewSirenko AndrewSirenko

@torredil torredil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ElijahQuinones @torredil @k8s-ci-robot @AndrewSirenko