WIP Improved Unit-Test Coverage for Issue #703 (please see #736)

[aarongalang]

What type of PR is this?
test

What this PR does / why we need it:
Adds unit-tests to pkg folder for improved coverage

Which issue(s) this PR fixes:
#703

Fixes #

Requirements:

• adds unit tests
• tested upgrade from previous version

Special notes for your reviewer:

Release note:

none

[linux-foundation-easycla]

• ✅ login: aarongalang / name: Aaron Galang (cfa6397, ade9f5a, cd10164, 45b7f09, d022df0, 54ec7bf, ed854d8, c1e1379, 984f16a, 80a8c8b, aa0748b, 4e58c74, b753585, 1b17213, 0ba1f23, f4ed930, c46b0ac, a7f487c, 2b22558, 927afaa, a696421, cdd40cd, 7e57ff2, 1c1bd9d, 21105dd, 2f5e237, 85b073b, 4cf5c77, 3698bf5, 7cf6052)
• ❌ The commit (f7a4076). This user is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.

[k8s-ci-robot]

Welcome @aarongalang!

It looks like this is your first PR to kubernetes-sigs/blob-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/blob-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @aarongalang. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aarongalang
Once this PR has been reviewed and has the lgtm label, please assign andyzhangx for approval by writing /assign @andyzhangx in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[andyzhangx]

thanks, could you:

• sign off the cla
• fix the test failure

Thanks.

[aarongalang]

Test Failure should be fixed now with the faulty test case removed in nodeserver test. CLA is signed, but I'm not sure why that particular commit isn't using my user id

[andyzhangx]

@aarongalang could you fix the golint error? Thanks.

run golangci-lint
  Running [/home/runner/golangci-lint-1.45.2-linux-amd64/golangci-lint run --out-format=github-actions -E=gofmt,deadcode,unused,varcheck,ineffassign,revive,misspell,exportloopref,asciicheck,bodyclose,depguard,dogsled,dupl,durationcheck,errname,errorlint,forbidigo -D=staticcheck --timeout=30m0s] in [] ...
  Error: 451-483 lines are duplicate of `pkg/blob/controllerserver_test.go:484-516` (dupl)
  Error: 484-516 lines are duplicate of `pkg/blob/controllerserver_test.go:451-483` (dupl)
  Error: Error return value of `(k8s.io/client-go/kubernetes/typed/core/v1.SecretInterface).Create` is not checked (errcheck)
  Error: Error return value of `(k8s.io/client-go/kubernetes/typed/core/v1.SecretInterface).Create` is not checked (errcheck)
  Warning: context-as-argument: context.Context should be the first parameter of a function (revive)
  Warning: var-declaration: should drop = nil from declaration of var expectedErr; it is the zero value (revive)
  Warning: var-declaration: should drop = nil from declaration of var expectedErr; it is the zero value (revive)
  Error: exporting a pointer for the loop variable test (exportloopref)
  Error: exporting a pointer for the loop variable test (exportloopref)
  Error: exporting a pointer for the loop variable test (exportloopref)

[aarongalang]

created a seperate pr for this issue, as I cant get rid of that first commit which lacks my userid. Will close this once the other(#736 ) is merged.

[andyzhangx]

EasyCLA is still not signed?

[aarongalang]

its on the other pr #736

[aarongalang]

first commit didnt use my user id, so I had to create a different branch with the changes