Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.31] Generate non-overlapping and non-mergable CIDRs with best effort (#8587) #8634

Open
wants to merge 1 commit into
base: release-1.31
Choose a base branch
from
Open

[release-1.31] Generate non-overlapping and non-mergable CIDRs with best effort (#8587) #8634

wants to merge 1 commit into from
+4 −2

Conversation

zarvd
Copy link
Contributor

@zarvd zarvd commented Mar 17, 2025

What type of PR is this?

/kind testing

What this PR does / why we need it:

cherry pick #8587

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 17, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 17, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @zarvd. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 17, 2025
feiskyer
feiskyer reviewed Mar 17, 2025
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 17, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2025
@feiskyer
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, zarvd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2025
@zarvd zarvd force-pushed the cp-8587-release-1.31 branch from 75f8c57 to 923f572 Compare March 17, 2025 04:58
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@zarvd
Copy link
Contributor Author

zarvd commented Mar 17, 2025

/retest

@zarvd zarvd force-pushed the cp-8587-release-1.31 branch from 923f572 to 2aee615 Compare March 17, 2025 20:51
@zarvd
Copy link
Contributor Author

zarvd commented Mar 18, 2025

/retest

@zarvd zarvd force-pushed the cp-8587-release-1.31 branch 2 times, most recently from e6b5399 to e03a5a2 Compare March 19, 2025 01:30
@zarvd
Copy link
Contributor Author

zarvd commented Mar 19, 2025

/retest

@zarvd zarvd force-pushed the cp-8587-release-1.31 branch from e03a5a2 to 84b2837 Compare March 20, 2025 00:23
@k8s-ci-robot
Copy link
Contributor

@zarvd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cloud-provider-azure-e2e-ccm-capz-1-31 84b2837 link true /test pull-cloud-provider-azure-e2e-ccm-capz-1-31

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@lzhecheng lzhecheng Awaiting requested review from lzhecheng

@MartinForReal MartinForReal Awaiting requested review from MartinForReal

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/testing ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zarvd @k8s-ci-robot @feiskyer