Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Clarify that the ROSA provider is currently for ROSA HCP clusters #5268

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

mjlshen
Copy link
Contributor

@mjlshen mjlshen commented Jan 8, 2025

What type of PR is this?
/kind documentation

What this PR does / why we need it:
The more explicit product name is ROSA HCP, see issue for more details

Which issue(s) this PR fixes:
Fixes #5257

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 8, 2025
@k8s-ci-robot k8s-ci-robot added needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 8, 2025
@mjlshen
Copy link
Contributor Author

mjlshen commented Jan 8, 2025

/assign mzazrivec serngawy

Just as an fyi!

@k8s-ci-robot
Copy link
Contributor

@mjlshen: GitHub didn't allow me to assign the following users: mzazrivec.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign mzazrivec serngawy

Just as an fyi!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@serngawy
Copy link
Contributor

Thanks @mjlshen for the effort , Would you mind update the other docs as well. For example here at enabling ROSA HCP.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 16, 2025
@mjlshen
Copy link
Contributor Author

mjlshen commented Jan 16, 2025

Thanks @serngawy - I tried to take a more thorough pass through all the *.md files. Not sure if you would also like CRD descriptions updated, like

// BillingAccount is an optional AWS account to use for billing the subscription fees for ROSA clusters.

@mjlshen mjlshen changed the title 📖 Clarify that creating-a-cluster.md steps are creating a ROSA HCP cluster 📖 Clarify that the ROSA provider is currently for ROSA HCP clusters Jan 16, 2025
@serngawy
Copy link
Contributor

Thanks @serngawy - I tried to take a more thorough pass through all the *.md files. Not sure if you would also like CRD descriptions updated, like

// BillingAccount is an optional AWS account to use for billing the subscription fees for ROSA clusters.

Thanks @mjlshen , the main focus is the md files but if you find places in CRDs that also can be fixed to ROSA-HCP that will be helpful.

@serngawy
Copy link
Contributor

@mjlshen Do you plan to update the PR ? I can approve it as it is the main focus was the .md files AND then we can have another PR for CRDs

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 5, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 6, 2025
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 6, 2025
@mjlshen
Copy link
Contributor Author

mjlshen commented Mar 6, 2025

@serngawy sorry for the delay, I updated the CRD description/comments here as well to keep things compact

Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/assign @nrb

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2025
@nrb
Copy link
Contributor

nrb commented Mar 11, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2025
@k8s-ci-robot k8s-ci-robot merged commit 7e95486 into kubernetes-sigs:main Mar 11, 2025
18 checks passed
@mjlshen mjlshen deleted the rosa-hcp branch March 21, 2025 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

creating-a-cluster.md document should correctly mention ROSA HCP (not just ROSA)
5 participants