✨ Add ClusterClass support for EKS clusters #5375
Conversation
k8s-ci-robot
added
kind/feature
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
needs-priority
size/XXL
alexander-demicev
force-pushed
the
eksclusterclass
branch
from
6489bf0 to
fee134f
Compare
|
/test pull-cluster-api-provider-aws-e2e |
There was a problem hiding this comment.
This looks good @alexander-demicev .
Can you add an e2e test to cover creating a cluster with ClusterClass?
|
@richardcase yes, can I do it in a follow-up PR? I already have a draft locally |
alexander-demicev
force-pushed
the
eksclusterclass
branch
2 times, most recently
from
930fb59 to
ce8e91a
Compare
A follow-up is good, i think we'd want the e2e coverage before we release this though.....this feature will be really popular 😄 |
alexander-demicev
force-pushed
the
eksclusterclass
branch
from
775b63e to
12569ea
Compare
|
/test pull-cluster-api-provider-aws-e2e |
alexander-demicev
force-pushed
the
eksclusterclass
branch
from
12569ea to
b2f4d39
Compare
|
/test pull-cluster-api-provider-aws-e2e |
|
/test ? |
|
@richardcase: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-cluster-api-provider-aws-e2e-eks |
|
/milestone v2.9 |
|
@richardcase: The provided milestone is not valid for this repository. Milestones in this repository: [ Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
alexander-demicev
force-pushed
the
eksclusterclass
branch
from
b2f4d39 to
dfc8736
Compare
|
/test pull-cluster-api-provider-aws-e2e-eks |
alexander-demicev
force-pushed
the
eksclusterclass
branch
from
dfc8736 to
32e08aa
Compare
|
/test pull-cluster-api-provider-aws-e2e-eks |
k8s-ci-robot
added
the
needs-rebase
alexander-demicev
force-pushed
the
eksclusterclass
branch
from
32e08aa to
4049921
Compare
k8s-ci-robot
removed
the
needs-rebase
alexander-demicev
force-pushed
the
eksclusterclass
branch
from
4049921 to
cfede67
Compare
|
/test pull-cluster-api-provider-aws-e2e-eks |
|
@alexander-demicev - theres some issue with the e2e on main. One fix has gone on to main and we're just testing another and then it would be worth rebasing. Hopefully they will pass then. |
Signed-off-by: Alexandr Demicev <[email protected]>
Signed-off-by: Alexandr Demicev <[email protected]>
alexander-demicev
force-pushed
the
eksclusterclass
branch
from
cfede67 to
e7303da
Compare
|
/test pull-cluster-api-provider-aws-e2e-eks |
1 similar comment
|
/test pull-cluster-api-provider-aws-e2e-eks |
|
@alexander-demicev: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds ClusterClass support for EKS.
AWSManagedControlPlanebroke conversions and they have to be done manually.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #3166
Special notes for your reviewer:
Checklist:
Release note: