-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requeue instead of throwing an error when onwer of kind can't be found #417
Requeue instead of throwing an error when onwer of kind can't be found #417
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vishesh92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-cluster-api-cloudstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #417 +/- ##
==========================================
- Coverage 25.66% 25.43% -0.24%
==========================================
Files 59 67 +8
Lines 5563 6498 +935
==========================================
+ Hits 1428 1653 +225
- Misses 3996 4697 +701
- Partials 139 148 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Test Results : (tid-534)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Maybe we can add a unit test?
Test Results : (tid-540)
|
Test Results : (tid-541)
|
/lgtm good job @vishesh92 ! |
Issue #, if available:
#299
Description of changes:
This pull request includes improvements to error handling in both the reconciliation process and the affinity group checking function. The most important changes are:
Error handling improvements:
controllers/utils/base_reconciler.go
: Added a check for a specific error message when getting the owner of a kind and requeue the request with the error message if the owner is not found.test/e2e/common.go
: Added error handling when retrieving an affinity group by ID, ensuring that the test fails with a descriptive error message if the retrieval fails.Testing performed:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.