🌱 v1beta2: add v1beta2 paused condition for all objects #3394
+1,109
−143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
size/XL
chrischdi
force-pushed
the
pr-paused-v1beta2-condition
branch
from
de0e255 to
bc70ed0
Compare
k8s-ci-robot
removed
the
needs-rebase
chrischdi
force-pushed
the
pr-paused-v1beta2-condition
branch
from
bc70ed0 to
48f3daf
Compare
This was referenced Mar 14, 2025
k8s-ci-robot
added
size/XXL
chrischdi
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
chrischdi
added
the
tide/merge-method-squash
chrischdi
force-pushed
the
pr-paused-v1beta2-condition
branch
from
7e3ad5a to
888faf9
Compare
|
/hold Maybe wanna merge: first |
k8s-ci-robot
added
the
do-not-merge/hold
|
Added a link to the corresponding issue to the PR description |
sbueringer
reviewed
Mar 17, 2025
chrischdi
force-pushed
the
pr-paused-v1beta2-condition
branch
from
a39e2fe to
6a8eaf8
Compare
|
(for documentation) /hold To wait for:
|
| // VSphereClusterV1Beta2Status groups all the fields that will be added or modified in VSphereClusterStatus with the V1Beta2 version. | ||
| // See https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/proposals/20240916-improve-status-in-CAPI-resources.md for more context. | ||
| type VSphereClusterV1Beta2Status struct { | ||
| // conditions represents the observations of a VSphereCluster's current state. |
There was a problem hiding this comment.
reminder for the follow up PRs, we have to add the list of know conditions for each object
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 6aceb15c843d37413413a49d19e30de016ea33e5
|
chrischdi
force-pushed
the
pr-paused-v1beta2-condition
branch
from
6a8eaf8 to
d0edb96
Compare
k8s-ci-robot
removed
the
lgtm
|
@chrischdi: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
Thank you! /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: c4bb637b6308a2f8d76e7632dfe6277a1c58e9f1
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds v1beta2's paused condition handling to most resources we have.
Also adjusts predicates accordingly.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #3221