🌱 vspheredeploymentzone/vsphereclusteridentity: implement v1beta2 conditions, govmomi #3401
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/L
| conditions.MarkFalse(deploymentZoneCtx.VSphereDeploymentZone, infrav1.VSphereFailureDomainValidatedCondition, infrav1.HostsAffinityMisconfiguredReason, clusterv1.ConditionSeverityWarning, "vm host affinity is disabled") | ||
| default: | ||
| conditions.MarkTrue(deploymentZoneCtx.VSphereDeploymentZone, infrav1.VSphereFailureDomainValidatedCondition) |
There was a problem hiding this comment.
If I've seen it right, these never had an effect because the above function continued and either set true or a different false condition
chrischdi
force-pushed
the
pr-govmomi-vspheredeploymentzone
branch
2 times, most recently
from
d51f5a5 to
09f2df1
Compare
chrischdi
force-pushed
the
pr-govmomi-vspheredeploymentzone
branch
from
09f2df1 to
ff0d77d
Compare
chrischdi
changed the title
|
@chrischdi: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| VSphereDeploymentZoneFailureDomainHostsMisconfiguredV1Beta2Reason = "HostsMisconfigured" | ||
|
|
||
| // VSphereDeploymentZoneFailureDomainHostsAffinityMisconfiguredV1Beta2Reason surfaces when the failure domain's hosts for a VSphereDeploymentZone are misconfigured. | ||
| VSphereDeploymentZoneFailureDomainHostsAffinityMisconfiguredV1Beta2Reason = "HostsAffinityMisconfigured" |
| // VSphereClusterIdentity's CredentialsAvailable condition and corresponding reasons that will be used in v1Beta2 API version. | ||
| const ( | ||
| // VSphereClusterIdentityCredentialsAvailableV1Beta2Condition documents the status of the credentials for a VSphereClusterIdentity. | ||
| VSphereClusterIdentityCredentialsAvailableV1Beta2Condition = "CredentialsAvailable" |
There was a problem hiding this comment.
Wondering if this should be just Available
| // VSphereDeploymentZone's VCenterAvailable condition and corresponding reasons that will be used in v1Beta2 API version. | ||
| const ( | ||
| // VSphereDeploymentZoneVCenterAvailableV1Beta2Condition documents the status of vCenter for a VSphereDeploymentZone. | ||
| VSphereDeploymentZoneVCenterAvailableV1Beta2Condition = "VCenterAvailable" | ||
|
|
||
| // VSphereDeploymentZoneVCenterAvailableV1Beta2Reason surfaces when the vCenter for a VSphereDeploymentZone is available. | ||
| VSphereDeploymentZoneVCenterAvailableV1Beta2Reason = clusterv1.AvailableV1Beta2Reason | ||
|
|
||
| // VSphereDeploymentZoneVCenterUnreachableV1Beta2Reason surfaces when the vCenter for a VSphereDeploymentZone is unreachable. | ||
| VSphereDeploymentZoneVCenterUnreachableV1Beta2Reason = "VCenterUnreachable" | ||
|
|
||
| // VSphereDeploymentZoneVCenterAvailableDeletingV1Beta2Reason surfaces when the vCenter for a VSphereDeploymentZone is being deleted. | ||
| VSphereDeploymentZoneVCenterAvailableDeletingV1Beta2Reason = clusterv1.DeletingV1Beta2Reason | ||
| ) |
There was a problem hiding this comment.
in #3406 I have Available and NotAvailable as reasons for the VCenterAvalable condition on VSphereVM, wondering if we should align
What this PR does / why we need it:
Part of #3221
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #