🌱 vsphereclusteridentity: implement v1beta2 condition #3404
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
| @@ -117,12 +118,24 @@ func (r clusterIdentityReconciler) Reconcile(ctx context.Context, req reconcile. | |||
| } | |||
| if err := r.Client.Get(ctx, secretKey, secret); err != nil { | |||
| conditions.MarkFalse(identity, infrav1.CredentialsAvailableCondidtion, infrav1.SecretNotAvailableReason, clusterv1.ConditionSeverityWarning, err.Error()) | |||
| v1beta2conditions.Set(identity, metav1.Condition{ | |||
There was a problem hiding this comment.
TODO: ensure withownedconditions get set in patch!
|
/close Integrated into #3404 |
|
@chrischdi: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Part of #3221
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #