✨ Implement Priority
and Serial
settings for discovered handlers
#11818
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In-place upgrades defines
machine-updates
process as looping until completion for each registered updater.In order to leverage runtime extensions in processing these updaters, handler execution needs to be able to block (retry until completion) on individual updater, in case it responds with pending status before requesting other unfinished hooks. This PR introduces
serial
setting for the handler discovery.Additionally, current handlers list is not guarantied to be ordered, so it may cause a situation when:
On the second iteration:
To address this, a
priority
field is added, which allows updaters to declare execution order.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes rancher/highlander#118
/area runtime-sdk