Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Enable the conditions rule from KAL #11847

Merged
merged 1 commit into from
Feb 14, 2025
Merged

🌱 Enable the conditions rule from KAL #11847

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .golangci-kal.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,14 @@ linters-settings:
settings:
linters:
enable:
- "conditions" # Ensure conditions have the correct json tags and markers.

# Per discussion in July 2024, we are keeping phase fields for now.
# See https://github.com/kubernetes-sigs/cluster-api/pull/10897#discussion_r1685929508
# and https://github.com/kubernetes-sigs/cluster-api/pull/10897#discussion_r1685919394.
# - "nophase" # Phase fields are discouraged by the Kube API conventions, use conditions instead.

# Linters below this line are disabled, pending conversation on how and when to enable them.
# - "conditions" # Ensure conditions have the correct json tags and markers.
# - "commentstart" # Ensure comments start with the serialized version of the field name.
# - "integers" # Ensure only int32 and int64 are used for integers.
# - "jsontags" # Ensure every field has a json tag.
Expand Down Expand Up @@ -60,3 +61,7 @@ issues:
- path-except: "api/*"
linters:
- kal
- path: "api/v1beta1/*|api/v1alpha1/*"
text: "Conditions field must be a slice of metav1.Condition"
linters:
- kal
Loading