Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Enable integers lint of KAL #11887

Merged
merged 4 commits into from
Feb 26, 2025
Merged

🌱 Enable integers lint of KAL #11887

merged 4 commits into from
Feb 26, 2025

Conversation

sivchari
Copy link
Member

What this PR does / why we need it:

This PR is part of #11834 .
Enabled integers rule of KAL.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/kind api-change

@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 21, 2025
@sivchari
Copy link
Member Author

/assign @JoelSpeed

@sivchari
enable integers lint
eddd0f4 
Signed-off-by: sivchari <[email protected]>
@sivchari
fix cmd/clusterctl
a9250a3 
Signed-off-by: sivchari <[email protected]>
@sivchari
add exclude rules
5c34e51 
Signed-off-by: sivchari <[email protected]>
@sivchari sivchari force-pushed the enable-integers-lint branch from 1cbd7a6 to 5c34e51 Compare February 22, 2025 08:59
JoelSpeed
JoelSpeed reviewed Feb 24, 2025
View reviewed changes
@sbueringer sbueringer added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 24, 2025
@sbueringer
Copy link
Member

lgtm pending #11887 (comment)

@sbueringer sbueringer added the area/api Issues or PRs related to the APIs label Feb 24, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Feb 24, 2025
@sivchari
move integers linter
4f74fcc 
Signed-off-by: sivchari <[email protected]>
@k8s-ci-robot
Copy link
Contributor

@sivchari: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main 4f74fcc link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 32a8e93fab6e27d7295152aaafbb56fc370b26f4

@sbueringer
Copy link
Member

Thx!

/approve

@sbueringer sbueringer added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d23093a into kubernetes-sigs:main Feb 26, 2025
17 of 18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.10 milestone Feb 26, 2025
cprivitere pushed a commit to cprivitere/cluster-api that referenced this pull request Feb 27, 2025
@sivchari @cprivitere
🌱 Enable integers lint of KAL (kubernetes-sigs#11887)
d597e10 
* enable integers lint

Signed-off-by: sivchari <[email protected]>

* fix cmd/clusterctl

Signed-off-by: sivchari <[email protected]>

* add exclude rules

Signed-off-by: sivchari <[email protected]>

* move integers linter

Signed-off-by: sivchari <[email protected]>

---------

Signed-off-by: sivchari <[email protected]>
@JoelSpeed JoelSpeed mentioned this pull request Feb 27, 2025
Open
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@sbueringer sbueringer sbueringer left review comments

@JoelSpeed JoelSpeed JoelSpeed left review comments

Assignees

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Issues or PRs related to the APIs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.
5 participants
@sivchari @sbueringer @k8s-ci-robot @JoelSpeed @chrischdi