🌱 Implement a smoke test for clusterctl plugins #11950
Conversation
k8s-ci-robot
added
area/clusterctl
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/L
|
/hold Before I fix the problems with running the plugin test in the container |
k8s-ci-robot
added
the
do-not-merge/hold
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
| }, | ||
| } | ||
|
|
||
| tmpDir := os.TempDir() |
There was a problem hiding this comment.
| tmpDir := os.TempDir() | |
| tmpDir := t.TempDir() |
There was a problem hiding this comment.
This is not working in container environment due to limitations. It was my original approach.
| } | ||
|
|
||
| tmpDir := os.TempDir() | ||
| defer os.Remove(tmpDir) |
There was a problem hiding this comment.
| defer os.Remove(tmpDir) |
There was a problem hiding this comment.
The same reason as above
| ) | ||
|
|
||
| func Test_plugin(t *testing.T) { | ||
| if goutils.DefaultString(os.Getenv(forkEnvVar), "false") == strconv.FormatBool(false) { |
There was a problem hiding this comment.
Why do we need this check? I can't understand this situation.
There was a problem hiding this comment.
Please note that this code forks the test executable and runs it inside the test suite. The reason it uses this sub-hack is that the syscall.Exec does not return control back to the code after successful execution.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #10219
/area clusterctl