-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Validate that unstructued objects don't require scheme registration #3138
🌱 Validate that unstructued objects don't require scheme registration #3138
Conversation
If someone is interacting with objects through unstructured, we generally do not expect that to require any sort of registration in the scheme. It look like we never had any tests for this, this change adds them.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR validates that unstructured objects can be handled without requiring scheme registration, by updating test cases to pass a freshly initialized scheme to client.New.
- Updated multiple test cases to initialize the client with a new runtime scheme.
- Added tests covering various subresources such as Scale, ServiceAccount tokens, Pod evictions, Pod bindings, and CSR approvals.
Reviewed Changes
File | Description |
---|---|
pkg/client/client_test.go | Updated client.New calls to explicitly pass runtime.NewScheme() in tests |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Generally seems fine, can we please hold until after #3136 is merged? Just to avoid rebase on 3136 |
And wth is copilot doing? :) |
It is a review functionality you can request by adding it as a reviewer |
Sounds good, I just wanted proof that this actually works, there is no urgency in merging this |
Interesting, nice. How do I do that? Looks like I can't assign copilot via the UI. (probably because I'm not paying? :)) |
I cliked on |
If I click on the current PR on Copilot I get send to a page to signup for Copilot |
/lgtm |
LGTM label has been added. Git tree hash: bd1aef5244d9a25fe7a65fef06098a8b7424d7e9
|
If someone is interacting with objects through unstructured, we generally do not expect that to require any sort of registration in the scheme. It look like we never had any tests for this, this change adds them.