-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP chore(source): code cleanup, decouple and isolate logic #5186
Conversation
Signed-off-by: ivan katliarchuk <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ivankatliarchuk: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Signed-off-by: ivan katliarchuk <[email protected]>
/kind cleanup |
Signed-off-by: ivan katliarchuk <[email protected]>
Signed-off-by: ivan katliarchuk <[email protected]>
Signed-off-by: ivan katliarchuk <[email protected]>
Most of the work done in another PR |
Description
I was trying to implement support for
istio networking.istio.io/v1
. The approach is:networking.istio.io/v1alpha3
networking.istio.io/v1
Size of PR is quite big, as added bunch of tests, and new files do require licences headers. I could split this PR on mulitple.
Tried to add support for
v1alpha3
andv1
Istio apis. The code is here gofogo#10. However the code coupling is too high, there is a benefit to create specific packages in sources to reduce coupling. In isolation is easier to improve code coverage as well. This will also enable us to improve code coverage through isolated testing.Not resolves, but will simplify implementation for following issues
Relates #4473
Relates #2798
Relates #4786
The idea is to support multiple api versions for istion
"networking.istio.io/v1alpha3"
and"networking.istio.io/v1"
for a period of time. this require some refactoring beforehead, as in source directory code is tightly coupledChecklist