Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP chore(source): code cleanup, decouple and isolate logic #5186

Closed

Conversation

ivankatliarchuk
Copy link
Contributor

@ivankatliarchuk ivankatliarchuk commented Mar 16, 2025

Description

I was trying to implement support for istio networking.istio.io/v1. The approach is:

  • support networking.istio.io/v1alpha3
  • add support for networking.istio.io/v1

Size of PR is quite big, as added bunch of tests, and new files do require licences headers. I could split this PR on mulitple.

Tried to add support for v1alpha3 and v1 Istio apis. The code is here gofogo#10. However the code coupling is too high, there is a benefit to create specific packages in sources to reduce coupling. In isolation is easier to improve code coverage as well. This will also enable us to improve code coverage through isolated testing.

Not resolves, but will simplify implementation for following issues
Relates #4473
Relates #2798
Relates #4786

The idea is to support multiple api versions for istion "networking.istio.io/v1alpha3" and "networking.istio.io/v1" for a period of time. this require some refactoring beforehead, as in source directory code is tightly coupled

  • no chnges to business logic or current functionality
  • added more descriptive logs to even handler
  • added tests for even handlers

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 16, 2025
@ivankatliarchuk ivankatliarchuk marked this pull request as draft March 16, 2025 12:46
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign szuecs for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 16, 2025
@k8s-ci-robot
Copy link
Contributor

@ivankatliarchuk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-external-dns-licensecheck 222be63 link true /test pull-external-dns-licensecheck

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 16, 2025
@ivankatliarchuk ivankatliarchuk changed the title WIP chore(source): code cleanup WIP chore(source): code cleanup, decouple and isolate logic Mar 16, 2025
@ivankatliarchuk
Copy link
Contributor Author

/kind cleanup
/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. labels Mar 16, 2025
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 16, 2025
@ivankatliarchuk
Copy link
Contributor Author

Most of the work done in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants