Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support full duplex streaming in body-based routing extension #463

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

rramkumar1
Copy link
Contributor

@rramkumar1 rramkumar1 commented Mar 7, 2025

Ref: #321

I updated the unit test in request_test.go but I owe unit tests for the changes in server.go and also updates to the integration test.

Will send a separate PR for that.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 7, 2025
@k8s-ci-robot k8s-ci-robot requested review from Jeffwan and kfswain March 7, 2025 15:02
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 7, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @rramkumar1. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 7, 2025
Copy link

netlify bot commented Mar 7, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit aa6139d
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/67daf07cacce2600094b2f18
😎 Deploy Preview https://deploy-preview-463--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2025
@rramkumar1 rramkumar1 changed the title [WIP] Support full duplex streaming in body-based routing extension Support full duplex streaming in body-based routing extension Mar 11, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2025
@rramkumar1
Copy link
Contributor Author

/assign @kfswain
/assign @ahg-g

@kfswain
Copy link
Collaborator

kfswain commented Mar 12, 2025

/lgtm
/hold

I think this works, but we might want to refactor this a tad to try to bring the Send() logic into the same place. Author's disgression.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Mar 12, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Mar 12, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 12, 2025
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 17, 2025
@rramkumar1 rramkumar1 force-pushed the bbr-streaming branch 3 times, most recently from d6220ef to dff3a12 Compare March 17, 2025 14:41
Copy link
Member

@hzxuzhonghu hzxuzhonghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As envoy documents, all http headers are normalized ti lowercase, not sure the extproc bypas that or not.

@kfswain
Copy link
Collaborator

kfswain commented Mar 19, 2025

I think we can significantly simplify BBR, but I dont think it needs to block this PR. @rramkumar1 can you spin up some issues for that?
I think we can:

  • Remove k8s logic
  • cleanup full duplex logic
  • Document how this would hook into an OSS GW(the expectation is that this extension would run before any HTTP routing is done, we should have an example of that via the EnvoyPatchPolicy or an OSS GW implementation doing that)
  • add a bit more testing

Otherwise I think this PR is mergable

@rramkumar1 rramkumar1 force-pushed the bbr-streaming branch 2 times, most recently from 23b5c52 to e6d3ac2 Compare March 19, 2025 16:14
@rramkumar1
Copy link
Contributor Author

I think we can significantly simplify BBR, but I dont think it needs to block this PR. @rramkumar1 can you spin up some issues for that? I think we can:

  • Remove k8s logic
  • cleanup full duplex logic
  • Document how this would hook into an OSS GW(the expectation is that this extension would run before any HTTP routing is done, we should have an example of that via the EnvoyPatchPolicy or an OSS GW implementation doing that)
  • add a bit more testing

Otherwise I think this PR is mergable

Filed #535 for removing the k8s dependency
Have #443 that is already tracking addition testing
Filed #536 for adding usage examples

In terms of cleanup, let's follow-up offline on that so we can discuss how we want things to look.

@kfswain
Copy link
Collaborator

kfswain commented Mar 19, 2025

In terms of cleanup, let's follow-up offline on that so we can discuss how we want things to look.
SG, I'm cleaning up EPP streaming as well.

/lgtm
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2025
@rramkumar1
Copy link
Contributor Author

/retest

@kfswain
Copy link
Collaborator

kfswain commented Mar 19, 2025

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 19, 2025
@kfswain
Copy link
Collaborator

kfswain commented Mar 19, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kfswain, rramkumar1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2025
@k8s-ci-robot k8s-ci-robot merged commit 079236c into kubernetes-sigs:main Mar 19, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants