-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support full duplex streaming in body-based routing extension #463
Conversation
Hi @rramkumar1. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bbe95e8
to
b55c884
Compare
b55c884
to
03694ce
Compare
/lgtm I think this works, but we might want to refactor this a tad to try to bring the |
/ok-to-test |
03694ce
to
4407e0e
Compare
d6220ef
to
dff3a12
Compare
dff3a12
to
f2344ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As envoy documents, all http headers are normalized ti lowercase, not sure the extproc bypas that or not.
I think we can significantly simplify BBR, but I dont think it needs to block this PR. @rramkumar1 can you spin up some issues for that?
Otherwise I think this PR is mergable |
23b5c52
to
e6d3ac2
Compare
e6d3ac2
to
aa6139d
Compare
Filed #535 for removing the k8s dependency In terms of cleanup, let's follow-up offline on that so we can discuss how we want things to look. |
/lgtm |
/retest |
/unhold |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kfswain, rramkumar1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ref: #321
I updated the unit test in request_test.go but I owe unit tests for the changes in server.go and also updates to the integration test.
Will send a separate PR for that.