Apply validation to check the conversion

[sbin64]

Closes: #4297

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: sbin64 / name: Saan (25332cd, 3a9629c, 7a5861d)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sbin64
Once this PR has been reviewed and has the lgtm label, please assign kavinjsir for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @sbin64!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @sbin64. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[camilamacedo86]

I need to re-check the code above to confirm think the ns is true only right?

[sbin64]

Yes. And I have added validation check for v1 -> v2 conversion. Thanks

[camilamacedo86]

I think we should not "-n", "test-ns",
The true will get the CRs from the namespace defined in the TestContext
Give a look on its implementation

[sbin64]

Yes, I found that.

Do I need establish a CRD for that? sth like

crdName := "conversiontests." + kbc.Group
Eventually(func(g Gomega) {
    _, err := kbc.Kubectl.Get(false, "crd", crdName)
    g.Expect(err).NotTo(HaveOccurred(), "CRD %s not found", crdName)
}

[camilamacedo86]

/ok-to-test

[k8s-ci-robot]

@sbin64: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubebuilder-e2e-k8s-1-31-4	7a5861d	link	true	/test pull-kubebuilder-e2e-k8s-1-31-4
pull-kubebuilder-e2e-k8s-1-30-8	7a5861d	link	true	/test pull-kubebuilder-e2e-k8s-1-30-8
pull-kubebuilder-e2e-k8s-1-32-0	7a5861d	link	true	/test pull-kubebuilder-e2e-k8s-1-32-0

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.