-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add kubebuilderVersion field to PROJECT file #4621
base: master
Are you sure you want to change the base?
✨ Add kubebuilderVersion field to PROJECT file #4621
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vitorfloriano The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @vitorfloriano. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Terrific 🎉 . Thank you a lot for your contribution 🥇
@@ -61,6 +61,7 @@ type Cfg struct { | |||
Domain string `json:"domain,omitempty"` | |||
Repository string `json:"repo,omitempty"` | |||
Name string `json:"projectName,omitempty"` | |||
KubebuilderVersion string `json:"kubebuilderVersion,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we change this to CliVersion
as well? (and keep the tag)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we said in the issue to be KubebuilderVersion, but because other projects can use it as a lib. I think a generic name might be better.
07689e2
to
dff6ef1
Compare
This commit adds a new field to the PROJECT file: kubebuilderVersion. Additionally, it updates the documentation in the Project Configuration Reference to include the new kubebuilderVersion field. It also updates the PROJECT file scaffolded in the docs and in testdata.
dff6ef1
to
6ab4d37
Compare
This PR adds a new field to the PROJECT file:
kubebuilderVersion.
Additionally, it updates the documentation in the Project Configuration Reference to include the new
kubebuilderVersion
field.It also updates the PROJECT file scaffolded in the docs and in testdata.
Closes: #4398
Test Steps:
~/kubebuilder$ goreleaser release --snapshot --skip=publish -f ./build/.goreleaser.yml
~/kubebuilder/dist/kubebuilder_linux_amd64_v1/kubebuilder init --domain example.com --repo github.com/test/example-operator