Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP TAS flake test #4475

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

nasedil
Copy link
Contributor

@nasedil nasedil commented Mar 4, 2025

What type of PR is this?

/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #4140

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/flake Categorizes issue or PR as related to a flaky test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 4, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nasedil
Once this PR has been reviewed and has the lgtm label, please assign tenzen-y for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @nasedil. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 4, 2025
Copy link

netlify bot commented Mar 4, 2025

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 34aa4fe
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67caaf46449a240008cd8d47

@nasedil nasedil marked this pull request as draft March 4, 2025 15:05
@nasedil nasedil changed the title [WIP] TAS flake test WIP TAS flake test Mar 4, 2025
@nasedil
Copy link
Contributor Author

nasedil commented Mar 4, 2025

/test ci "TopologyAwareScheduling when Creating a Pod requesting TAS should admit a single Pod via TAS"

@k8s-ci-robot
Copy link
Contributor

@nasedil: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test ci "TopologyAwareScheduling when Creating a Pod requesting TAS should admit a single Pod via TAS"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nasedil
Copy link
Contributor Author

nasedil commented Mar 5, 2025

@mimowo can you make it ok-to-test? And I want to clarify whether typing /test ci "TopologyAwareScheduling when Creating a Pod requesting TAS should admit a single Pod via TAS" is the correct way to test this particular test?

@tenzen-y
Copy link
Member

tenzen-y commented Mar 5, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 5, 2025
@mimowo
Copy link
Contributor

mimowo commented Mar 5, 2025

/ok-to-test

@nasedil
Copy link
Contributor Author

nasedil commented Mar 5, 2025

/test ci "TopologyAwareScheduling when Creating a Pod requesting TAS should admit a single Pod via TAS"

@k8s-ci-robot
Copy link
Contributor

@nasedil: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-kueue-build-image-main
/test pull-kueue-test-e2e-customconfigs-main
/test pull-kueue-test-e2e-main-1-29
/test pull-kueue-test-e2e-main-1-30
/test pull-kueue-test-e2e-main-1-31
/test pull-kueue-test-e2e-main-1-32
/test pull-kueue-test-e2e-multikueue-main
/test pull-kueue-test-e2e-tas-main
/test pull-kueue-test-integration-main
/test pull-kueue-test-integration-multikueue-main
/test pull-kueue-test-scheduling-perf-main
/test pull-kueue-test-unit-main
/test pull-kueue-verify-main

Use /test all to run all jobs.

In response to this:

/test ci "TopologyAwareScheduling when Creating a Pod requesting TAS should admit a single Pod via TAS"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nasedil
Copy link
Contributor Author

nasedil commented Mar 5, 2025

/test pull-kueue-test-e2e-main-1-31

@nasedil
Copy link
Contributor Author

nasedil commented Mar 5, 2025

/test pull-kueue-test-e2e-main-1-32

@nasedil
Copy link
Contributor Author

nasedil commented Mar 7, 2025

/test pull-kueue-test-e2e-main-1-31

@nasedil
Copy link
Contributor Author

nasedil commented Mar 7, 2025

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 18, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

@nasedil: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kueue-test-integration-main 34aa4fe link true /test pull-kueue-test-integration-main
pull-kueue-test-integration-multikueue-main 34aa4fe link true /test pull-kueue-test-integration-multikueue-main
pull-kueue-test-e2e-main-1-30 34aa4fe link true /test pull-kueue-test-e2e-main-1-30
pull-kueue-test-e2e-main-1-32 34aa4fe link true /test pull-kueue-test-e2e-main-1-32
pull-kueue-test-e2e-main-1-29 34aa4fe link true /test pull-kueue-test-e2e-main-1-29
pull-kueue-test-e2e-main-1-31 34aa4fe link true /test pull-kueue-test-e2e-main-1-31
pull-kueue-test-scheduling-perf-main 34aa4fe link true /test pull-kueue-test-scheduling-perf-main
pull-kueue-test-e2e-multikueue-main 34aa4fe link true /test pull-kueue-test-e2e-multikueue-main
pull-kueue-test-e2e-certmanager-main 34aa4fe link true /test pull-kueue-test-e2e-certmanager-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/flake Categorizes issue or PR as related to a flaky test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flaky test] TopologyAwareScheduling when Creating a Pod requesting TAS should admit a single Pod via TAS
4 participants