Replace deprecated linters

[RainbowMango]

What this PR does / why we need it:
This PR updates unsupported configurations of golangci-lint and replaces deprecated linter.

The exportloopref has been deprecated from golangci-lint@v1.60.2 and replaced by copyloopvar.

The typecheck has been removed from golangci-lint:

-bash-5.0# golangci-lint linters | grep typecheck | wc -l 
0
-bash-5.0# 
-bash-5.0# golangci-lint version
golangci-lint has version 1.61.0 built with go1.23.1 from a1d6c560 on 2024-09-09T17:44:42Z

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[richabanker]

/triage accepted
/assign @dgrisonnet

[RainbowMango]

I'm exploring this weird failing test:

pkg/api/pod_test.go:34:11: could not import k8s.io/apimachinery/pkg/types (-: could not load export data: internal error in importing "k8s.io/apimachinery/pkg/types" (unsupported version: 2); please report an issue) (typecheck)
	apitypes "k8s.io/apimachinery/pkg/types"
	         ^
pkg/api/node.go:89:3: undefined: klog (typecheck)
		klog.ErrorS(err, "Failed reading nodes metrics")
		^
pkg/api/node.go:105:3: undefined: klog (typecheck)
		klog.ErrorS(err, "Failed listing nodes", "labelSelector", labelSelector)
		^
pkg/api/node.go:1[22](https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_metrics-server/1633/pull-metrics-server-verify/1902712244030935040#1:build-log.txt%3A22):3: undefined: klog (typecheck)
		klog.ErrorS(err, "Failed getting node", "node", klog.KRef("", name))

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RainbowMango
Once this PR has been reviewed and has the lgtm label, please ask for approval from dgrisonnet. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[RainbowMango]

@dgrisonnet Could you please take a look at this? this is the blocker of #1585.

[dgrisonnet]

10 minutes is a huge bump, could we perhaps squeeze it down to 5 minutes and the jobs would still pass?

[RainbowMango]

Wow, I just noticed that the timeout in the configuration file is being overwritten by the --timeout flag in the Makefile:

metrics-server/Makefile

Line 244 in 0dcee07

$(GOPATH)/bin/golangci-lint run --timeout 10m || (echo 'Run "make update"' && exit 1)

So, this is not a bump at all :) :) :)

I just removed the --timeout flag from Makefile, it makes it easier to manage the golangci-lint configurations from one place.

[RainbowMango]

I tried to squeeze it down to 5 minutes, but the jobs failed due to exceeding the timeout:
echo from https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_metrics-server/1633/pull-metrics-server-verify/1903279512716578816

golangci/golangci-lint info found version: 1.64.8 for v1.64.8/linux/amd64
/home/prow/go/bin/golangci-lint run || (echo 'Run "make update"' && exit 1)
level=error msg="Timeout exceeded: try increasing it by passing --timeout option"

[RainbowMango]

@dgrisonnet Could you please take another look?

By the way, I‘d like to help bump the Kubernetes dependencies to v1.32, before that, we need to resolve the blocking CI issues.
Would be appreciated if I could get your support.