Remove a category label needs-* when the user is defining one
#370
Conversation
k8s-ci-robot
added
the
triage/unresolved
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: danilo-gemoli The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
requested review from
cjwagner,
droslean,
MadhavJivrajani and
Priyankasaggu11929
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for k8s-prow ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/retest-required |
| // labels := []string{"triage/unresolved", "area/testing"} | ||
| // needsLabels := []string{"triage"} | ||
| // result := []string{"triage"} | ||
| func getCategoriesFromLabels(labels, needsLabels []string) sets.Set[string] { |
There was a problem hiding this comment.
| func getCategoriesFromLabels(labels, needsLabels []string) sets.Set[string] { | |
| func getCategoriesFromLabels(labels, needsLabels []string) sets.Set[string] { | |
| needsLabelsSet := sets.New(needsLabels...) | |
| categories := sets.New[string]() | |
| for _, label := range labels { | |
| if prefix, _, found := strings.Cut(label, "/"); found && needsLabelsSet.Has(prefix) { | |
| categories.Insert(prefix) | |
| } | |
| } | |
| return categories | |
| } |
Just for you to consider
There was a problem hiding this comment.
Weak -1 from me, I'm a fan of private-unless-proven-to-be-necessary-public 😓
There was a problem hiding this comment.
Its my bad. I meant internals of the function, my intention was not to propose to make it public. Let me correct that.
There was a problem hiding this comment.
Corrected, again comment is about internals not about publicity, sorry for the confusion.
|
Is it in any way related to #344? |
|
Yeah I'm also curious about the relation to #344 b/c I thought we discovered that was a config issue |
| // labels := []string{"triage/unresolved", "area/testing"} | ||
| // needsLabels := []string{"triage"} | ||
| // result := []string{"triage"} | ||
| func getCategoriesFromLabels(labels, needsLabels []string) sets.Set[string] { |
There was a problem hiding this comment.
Weak -1 from me, I'm a fan of private-unless-proven-to-be-necessary-public 😓
| // Example: | ||
| // | ||
| // labels := []string{"triage/unresolved", "area/testing"} | ||
| // needsLabels := []string{"triage"} |
|
Yes, this PR is supposed to handle #344. Thanks both for the reviews but I'll put this on hold and eventually close it if kubernetes/test-infra#34255 turns out to be enough. |
k8s-ci-robot
added
the
do-not-merge/hold
|
/area plugins |
k8s-ci-robot
added
the
area/plugins
These are the available
needs-*categories that can be applied to an issue (see here):When an issue has one of those, as
needs-triage, and the user is defining that category like so:then the
needs-triagewill be removed.