PR comment for empty aliases, handle other cases. #390
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
Hi @nikhilnishad-goog. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nikhilnishad-goog The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
requested review from
cjwagner,
jmguzik,
MadhavJivrajani and
Priyankasaggu11929
k8s-ci-robot
added
the
size/L
✅ Deploy Preview for k8s-prow ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
| @@ -1435,3 +1440,109 @@ func testOwnersRemoval(clients localgit.Clients, t *testing.T) { | |||
| func TestOwnersRemovalV2(t *testing.T) { | |||
| testOwnersRemoval(localgit.NewV2, t) | |||
| } | |||
|
|
|||
| func TestHandleParseAliasesConfigWarningLabels(t *testing.T) { | |||
There was a problem hiding this comment.
This indirection isn't necessary. In fact, we should clean up the functions that are labeled v2 as that is now the only way it is tested. That effort can be separate from this PR, but there is no need to have this indirection here.
Fixes #360
Handle cases as discussed in the issue. Add a PR comment for cases where aliases are empty instead of throwing errors. This is because lot of existing users have empty aliases and their approvals were broken.