-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(spyglass) allow configuration of sandbox permissions per lense - try 2 #392
base: main
Are you sure you want to change the base?
Conversation
This provides the ability to configure iframe sandbox permissions pr lense. This allows the operator of the prow installation to define which permissions it trust to each lense. PR comes from the ideas and discussions in kubernetes-sigs#294 Signed-off-by: Roy Sindre Norangshol <[email protected]>
if providing sandbox iframe sandbox permissions configuration which is empty, it should provide no prvileges for the sandbox and not fall back to the defaults. if you want defaults, you should not configure the iframe.sandbox_permissions. Signed-off-by: Roy Sindre Norangshol <[email protected]>
…e sandbox permissions..
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: norrs The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @norrs. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for k8s-prow ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/cc |
@norrs: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
WIP: This is a try 2 after this caused things to go boooom ( #371 , #369 ) and natural follow up for https://github.com/kubernetes-sigs/prow/pull/296/files
This is not ready for review, just leaving it as draft to not loose track of it. Force-pushes will appear in branch..