Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(spyglass) allow configuration of sandbox permissions per lense - try 2 #392

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

norrs
Copy link
Contributor

@norrs norrs commented Mar 5, 2025

WIP: This is a try 2 after this caused things to go boooom ( #371 , #369 ) and natural follow up for https://github.com/kubernetes-sigs/prow/pull/296/files

This is not ready for review, just leaving it as draft to not loose track of it. Force-pushes will appear in branch..

norrs added 3 commits March 5, 2025 15:32
This provides the ability to configure iframe sandbox permissions pr lense.
This allows the operator of the prow installation to define which permissions
it trust to each lense.

PR comes from the ideas and discussions in
kubernetes-sigs#294

Signed-off-by: Roy Sindre Norangshol <[email protected]>
if providing sandbox iframe sandbox permissions configuration which is empty,
it should provide no prvileges for the sandbox and not fall back to the
defaults.

if you want defaults, you should not configure the iframe.sandbox_permissions.

Signed-off-by: Roy Sindre Norangshol <[email protected]>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 5, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: norrs
Once this PR has been reviewed and has the lgtm label, please assign cjwagner, michelle192837 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 5, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 5, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @norrs. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

netlify bot commented Mar 5, 2025

Deploy Preview for k8s-prow ready!

Name Link
🔨 Latest commit 4237338
🔍 Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/67c861227efc1000082a2d03
😎 Deploy Preview https://deploy-preview-392--k8s-prow.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 5, 2025
@petr-muller
Copy link
Contributor

/cc
/ok-to-test

@k8s-ci-robot k8s-ci-robot requested a review from petr-muller March 5, 2025 22:29
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 5, 2025
@k8s-ci-robot
Copy link
Contributor

@norrs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-prow-unit-test 4237338 link true /test pull-prow-unit-test
pull-prow-verify-lint 4237338 link true /test pull-prow-verify-lint
pull-prow-unit-test-race-detector-nonblocking 4237338 link false /test pull-prow-unit-test-race-detector-nonblocking

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants