Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update label assignments in OWNERS files to labels migrated from k/test-infra #395

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

hector-vido
Copy link
Contributor

@hector-vido hector-vido commented Mar 11, 2025

This will match the labels movement that happened on kubernetes/test-infra#34479

Also, created OWNERS for gangway and moonraker.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 11, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @hector-vido. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 11, 2025
Copy link

netlify bot commented Mar 11, 2025

Deploy Preview for k8s-prow ready!

Name Link
🔨 Latest commit 58205e5
🔍 Latest deploy log https://app.netlify.com/sites/k8s-prow/deploys/67d0557018f95c000830fd93
😎 Deploy Preview https://deploy-preview-395--k8s-prow.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@petr-muller
Copy link
Contributor

/retitle Update label assignments in OWNERS files to labels migrated from k/test-infra

@k8s-ci-robot k8s-ci-robot changed the title Updated OWNERS labels Update label assignments in OWNERS files to labels migrated from k/test-infra Mar 11, 2025
@petr-muller
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 11, 2025
Copy link
Contributor

@petr-muller petr-muller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need OWNERS files with labels for the new labels - gangway and moonraker. Are you planning to do that in a followup?

@hector-vido hector-vido force-pushed the update-owners-labels branch 2 times, most recently from ff01a74 to cb668a2 Compare March 11, 2025 13:18
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 11, 2025
@hector-vido hector-vido force-pushed the update-owners-labels branch from cb668a2 to 8ae6eb9 Compare March 11, 2025 13:33
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 11, 2025
@hector-vido hector-vido force-pushed the update-owners-labels branch from 8ae6eb9 to 58205e5 Compare March 11, 2025 15:23
Copy link
Contributor

@petr-muller petr-muller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hector-vido, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2025
@k8s-ci-robot k8s-ci-robot merged commit a3626d1 into kubernetes-sigs:main Mar 13, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants