fix cnsunregister API to not use CNS metadata #3192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divyenpatel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
divyenpatel
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
divyenpatel
force-pushed
the
fix-cns-unregister-volume-to-not-use-cns-metadata
branch
2 times, most recently
from
940e475 to
7532697
Compare
divyenpatel
force-pushed
the
fix-cns-unregister-volume-to-not-use-cns-metadata
branch
from
7532697 to
cd909a4
Compare
divyenpatel
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR is removing usage of CNS Volume metadata for CnsUnregisterVolume API.
CnsUnregisterVolume API was querying CNS with the volume ID and if volume is not found in CNS, API marks CnsUnregisterVolume as sucess. We may have stale metadata in the CNS, and we can rely on it.
With this PR, reconciler is finding PV/PVC in the cluster for the volume being unregistered, and if they are present and not in use by any Pod or not attached to any VM service vm, then allow de-registering volume.
Testing done:
In Progress
Special notes for your reviewer:
Release note: