Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust to govmomi simulator breaking changes #3219

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dougm
Copy link
Member

@dougm dougm commented Mar 11, 2025

The simulator.Map package variable has been removed from govmomi. See: vmware/govmomi#3701

The simulator.Map usage had been read-only, so changed to use vim25.Client instead. These tests don't have access to simulator instance Context, so we can't use the in-memory 'model.Map()' as pkg/common/cns-lib/vsphere/virtualmachine_test.go does.

The simulator.Map package variable has been removed from govmomi.
See: vmware/govmomi#3701

The simulator.Map usage had been read-only, so changed to use vim25.Client instead.
These tests don't have access to simulator instance Context, so we can't use the
in-memory 'model.Map()' as pkg/common/cns-lib/vsphere/virtualmachine_test.go does.
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dougm
Once this PR has been reviewed and has the lgtm label, please assign sandeeppissay for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 11, 2025
@k8s-ci-robot
Copy link
Contributor

@dougm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-vsphere-csi-driver-unit-test 5b873de link true /test pull-vsphere-csi-driver-unit-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants